New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audit: limit non-failure cask output #10896
Conversation
Review period will end on 2021-03-23 at 00:00:00 UTC. |
@@ -56,6 +56,8 @@ def audit_args | |||
switch "--display-filename", | |||
description: "Prefix every line of output with the file or formula name being audited, to "\ | |||
"make output easy to grep." | |||
switch "--display-failures-only", | |||
description: "Only display casks that fail the audit. This is the default for formulae." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default for formulae.
Is this because there are no warnings for formulae or are warnings actually hidden by default for formulae?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But there's also no message shown if the audit succeeds. It's either no output or a list of problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 this is a big improvement. I agree with specifically not outputting warnings for Casks in the way we're using it for CI.
Review period ended. |
631bf46
to
b4a36be
Compare
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This PR changes how
brew audit
outputs cask audit summaries.By default,
brew audit
will not output anypassed
messaging unless--verbose
is passed or there was only one named argument. Warnings will still be shown.If the
--display-failures-only
flag is passed, warnings will also be silenced.I added the
--display-failures-only
flag to thebrew audit
calls in thetests
workflow. I don't think there's a benefit to seeing the huge number of warnings in this situation. Warnings don't block CI here, so there's no point in showing them as it makes it harder to read when there are failures.