Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FormulaInstaller.prevent_build_flags #10904

Merged
merged 1 commit into from Mar 22, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Mar 22, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Responsibility of args should lie with the command itself. The args to check for here varied depending on whether it was an install, reinstall or upgrade.

If we want some sort of shared logic, I'd rather it was done in a more generic way - such as having some way to tag which options are "build flags" and iterating over those.

Fixes Homebrew/discussions#1104.

@BrewTestBot
Copy link
Member

Review period will end on 2021-03-23 at 16:15:39 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 22, 2021
@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Mar 22, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 22, 2021
@Bo98 Bo98 merged commit 555e936 into Homebrew:master Mar 22, 2021
@Bo98 Bo98 deleted the check_build_flags branch March 22, 2021 16:54
@MikeMcQuaid
Copy link
Member

Makes sense, thanks!

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants