github_packages: various improvements. #10932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2021-03-26 at 10:08:54 UTC. |
BrewTestBot
added
the
waiting for feedback
- validate all JSON files against their JSON schemas - remove existing/lingering JSON files - improve naming based on schema understanding - add more (empty) annotations hashes where valid - output prettier JSON - fix non-SHA256 output filenames
MikeMcQuaid
force-pushed
the
json_schema
branch
from
067b5ef
to
169a1ba
Compare
Bo98
reviewed
Mar 25, 2021
Comment on lines
+51
to
+52
| Homebrew.install_gem!("json-schema") | ||
| require "json-schema" |
There was a problem hiding this comment.
This gem is no longer maintained btw (voxpupuli/json-schema#423 (comment)), with json_schemer being the one recommended on the JSON Schema website.
There was a problem hiding this comment.
@Bo98 Argh. I'm going to merge this for now given the other improvements but I'll move to the new gem (likely next week).
|
Review period ended. |
BrewTestBot
removed
the
waiting for feedback
BrewTestBot
approved these changes
Mar 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-uploaded at https://github.com/orgs/Homebrew/packages/container/package/homebrew-core%2Flibev