Move YARD config into Library/Homebrew.
#10969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2021-03-31 at 02:41:10 UTC. |
BrewTestBot
added
the
waiting for feedback
reitermarkus
force-pushed
the
yard
branch
5 times, most recently
from
0567b26
to
437ef9b
Compare
MikeMcQuaid
reviewed
Mar 30, 2021
| @@ -0,0 +1,5 @@ | |||
| <p class="note private"> | |||
| <strong>This <%= object.type %> is part of a private API.</strong> | |||
| This <%= object.type %> may only be used in the <a href="https://github.com/Homebrew/brew">Homebrew/brew</a> repository. | |||
There was a problem hiding this comment.
Suggested change
| This <%= object.type %> may only be used in the <a href="https://github.com/Homebrew/brew">Homebrew/brew</a> repository. | |
| This <%= object.type %> should only be used in the <a href="https://github.com/Homebrew/brew">Homebrew/brew</a> repository. |
There was a problem hiding this comment.
Should is stronger and used more often in RFCs. I don't feel strongly, though.
Library/Homebrew/yard/templates/default/docstring/html/internal.erb
Outdated
Show resolved
Hide resolved
|
|
||
| def internal | ||
| return unless object.has_tag?(:api) | ||
| return unless object.tag(:api).text == "internal" |
There was a problem hiding this comment.
Suggested change
| return unless object.tag(:api).text == "internal" | |
| return if object.tag(:api).text != "internal" |
|
Review period ended. |
BrewTestBot
removed
the
waiting for feedback
BrewTestBot
previously approved these changes
Mar 31, 2021
MikeMcQuaid
previously approved these changes
Apr 1, 2021
5 tasks
Bo98
reviewed
Apr 1, 2021
Library/Homebrew/yard/templates/default/docstring/html/internal.erb
Outdated
Show resolved
Hide resolved
reitermarkus
dismissed stale reviews from MikeMcQuaid and BrewTestBot
via
6a59b87
BrewTestBot
previously approved these changes
Apr 2, 2021
BrewTestBot
approved these changes
Apr 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Also add support for
@api internaland improve message for@api private.