Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement nested url do API. #10973

Merged
merged 3 commits into from Apr 2, 2021
Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Mar 31, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Allows using nested url do blocks in order to allow fetching a chain of URLs for retrieving the final URL.

See Homebrew/homebrew-cask-versions#10620 for examples.

Also, skip auditing URLs using url do unless running with --online.

@reitermarkus reitermarkus changed the title Nested url do Implement nested url do API. Mar 31, 2021
@BrewTestBot
Copy link
Member

Review period will end on 2021-04-01 at 04:17:19 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 31, 2021
@reitermarkus reitermarkus requested a review from a team March 31, 2021 04:17
@reitermarkus reitermarkus added the cask Homebrew Cask label Mar 31, 2021
@vitorgalvao
Copy link
Member

Note: will need update to docs as well.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 1, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@reitermarkus reitermarkus merged commit 2bd0b6e into Homebrew:master Apr 2, 2021
@reitermarkus reitermarkus deleted the nested-url-do branch April 2, 2021 00:29
@github-actions github-actions bot added the outdated PR was locked due to age label May 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cask Homebrew Cask outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants