Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extract_plist strategy. #11028

Merged
merged 1 commit into from Apr 7, 2021

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Adapted from the bump-unversioned-casks command, extract the version from downloaded .apps or .pkgs.

@BrewTestBot
Copy link
Member

Review period will end on 2021-04-06 at 02:18:24 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 5, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 6, 2021
BrewTestBot
BrewTestBot previously approved these changes Apr 6, 2021
BrewTestBot
BrewTestBot previously approved these changes Apr 7, 2021
BrewTestBot
BrewTestBot previously approved these changes Apr 7, 2021
BrewTestBot
BrewTestBot previously approved these changes Apr 7, 2021
@reitermarkus reitermarkus marked this pull request as ready for review April 7, 2021 02:59
@reitermarkus reitermarkus merged commit 050ff99 into Homebrew:master Apr 7, 2021
@reitermarkus reitermarkus deleted the extract-plist-strategy branch April 7, 2021 20:30
@github-actions github-actions bot added the outdated PR was locked due to age label May 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants