Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github_packages: fix image_formula_name issue #11055

Merged
merged 1 commit into from Apr 7, 2021
Merged

github_packages: fix image_formula_name issue #11055

merged 1 commit into from Apr 7, 2021

Conversation

nandahkrishna
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Workflows on homebrew-core like this one were failing after #11054 was merged, I'm unsure if this is the right fix though.

@BrewTestBot
Copy link
Member

Review period will end on 2021-04-08 at 14:07:06 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 7, 2021
@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Apr 7, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 7, 2021
@nandahkrishna nandahkrishna merged commit 0cad0df into Homebrew:master Apr 7, 2021
@nandahkrishna nandahkrishna deleted the fix-github-packages branch April 7, 2021 14:33
@MikeMcQuaid
Copy link
Member

Good catch, thanks @nandahkrishna!

@github-actions github-actions bot added the outdated PR was locked due to age label May 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@MikeMcQuaid MikeMcQuaid Awaiting requested review from MikeMcQuaid

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nandahkrishna @BrewTestBot @MikeMcQuaid @Bo98