Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More GitHub Packages bulk upload fixes #11057

Merged
merged 1 commit into from Apr 7, 2021
Merged

More GitHub Packages bulk upload fixes #11057

merged 1 commit into from Apr 7, 2021

Conversation

MikeMcQuaid
Copy link
Member

  • replace invalid non-ASCII characters from the descriptions
  • handle invalid macOS versions on attempting to load old formulae from old bottles
  • let rubocop auto-remove a no-longer needed rubocop:disable
  • fix skopeo credentials argument

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Apr 7, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

BrewTestBot
BrewTestBot previously approved these changes Apr 7, 2021
View reviewed changes
@MikeMcQuaid
More GitHub Packages bulk upload fixes
8800b85 
- replace invalid non-ASCII characters from the descriptions
- handle invalid macOS versions on attempting to load old formulae from
  old bottles
- let `rubocop` auto-remove a no-longer needed `rubocop:disable`
- fix `skopeo` credentials argument
@MikeMcQuaid MikeMcQuaid merged commit 1435018 into Homebrew:master Apr 7, 2021
@MikeMcQuaid MikeMcQuaid deleted the github_packages_more_fixes branch April 7, 2021 16:26
@chrisayoub
Copy link

@MikeMcQuaid

Hi, this PR introduced the following bug for me:

Error: undefined method `encode' for nil:NilClass
Please report this issue:
  https://docs.brew.sh/Troubleshooting
/usr/local/Homebrew/Library/Homebrew/dev-cmd/bottle.rb:526:in `bottle_formula'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/bottle.rb:90:in `block in bottle'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/bottle.rb:89:in `each'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/bottle.rb:89:in `bottle'
/usr/local/Homebrew/Library/Homebrew/brew.rb:122:in `<main>'

In my case, my formula has no description.

@MikeMcQuaid MikeMcQuaid mentioned this pull request Apr 12, 2021
Merged
@MikeMcQuaid
Copy link
Member Author

@chrisayoub Opened https://github.com/Homebrew/brew/pull/11115/files to fix this.

@github-actions github-actions bot added the outdated PR was locked due to age label May 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeMcQuaid @BrewTestBot @chrisayoub