Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't forward options if none are given. #11063

Merged
merged 1 commit into from Apr 7, 2021

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Apr 7, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

When empty, passing **options calls version({}) instead of version().

Fixes #11059.

@reitermarkus reitermarkus added the critical Critical change which should be shipped as soon as possible. label Apr 7, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

BrewTestBot
BrewTestBot previously approved these changes Apr 7, 2021
@reitermarkus reitermarkus merged commit f1e9f8c into Homebrew:master Apr 7, 2021
@reitermarkus reitermarkus deleted the url-do-version branch April 7, 2021 22:32
@github-actions github-actions bot added the outdated PR was locked due to age label May 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Cask install failed on 3.0.11
2 participants