Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub packages: versioned formulae bottle names are displayed with escape characters when pouring bottle #11090

Closed
max-ae opened this issue Apr 9, 2021 · 0 comments · Fixed by #11092
Assignees
Labels
bug Reproducible Homebrew/brew bug outdated PR was locked due to age

Comments

@max-ae
Copy link
Contributor

max-ae commented Apr 9, 2021

brew config output

HOMEBREW_VERSION: 3.0.11-132-g79940b2
ORIGIN: https://github.com/Homebrew/brew
HEAD: 79940b2a273622e9540833b6bb06ecd78650bc1f
Last commit: 15 minutes ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 090d1077567a9b575e63a3d96ee077eb7dc6122f
Core tap last commit: 44 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: /private/tmp/com.apple.launchd.TVZFHl71HC/org.macosforge.xquartz:0
HOMEBREW_EDITOR: vim
HOMEBREW_MAKE_JOBS: 16
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: 16-core 64-bit kabylake
Clang: 12.0 build 1200
Git: 2.31.1 => /usr/local/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 11.2.3-x86_64
CLT: 12.4.0.0.1.1610135815
Xcode: 12.4
XQuartz: 2.7.11 => /opt/X11

brew doctor output

Your system is ready to brew.

The brew doctor above contains no "Warning" lines.

What were you trying to do (and why)?

Ran brew upgrade, ruby@2.6 got installed as a dependency, bottle got downloaded and poured

What happened (include all command output)?

The "pouring bottle" line displays versioned formulae bottle names with the '@' escape character '%40' if a package is downloaded from GitHub Packages. Downloading from Bintray displayed the correct bottle name with '@'

Github Packages:

==> Upgrading fastlane 2.179.0 -> 2.180.1
==> Downloading https://ghcr.io/v2/homebrew/core/ruby/2.6/manifests/2.6.6_1-1
######################################################################## 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/ruby/2.6/blobs/sha256:90a02e7c3985c005348fb1b750c22dce1ebbbd1a8854f3250da9956308c0c65f
==> Downloading from https://pkg-containers-az.githubusercontent.com/ghcr1/blobs/sha256:90a02e7c3985c005348fb1b750c22dce1ebbbd1a8854f3250da9956308c0c65f?se=2021-04-09T13%3A55%3A00Z
######################################################################## 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/fastlane/manifests/2.180.1
######################################################################## 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/fastlane/blobs/sha256:142d0d96c909b4d5e3d72a8195409237a41e09e1b160b79f2abc47f99230e635
==> Downloading from https://pkg-containers-az.githubusercontent.com/ghcr1/blobs/sha256:142d0d96c909b4d5e3d72a8195409237a41e09e1b160b79f2abc47f99230e635?se=2021-04-09T13%3A55%3A00Z
######################################################################## 100.0%
==> Installing dependencies for fastlane: ruby@2.6
==> Installing fastlane dependency: ruby@2.6
**==> Pouring ruby%402.6-2.6.6_1.big_sur.bottle.1.tar.gz**

Bintray:

❯ HOMEBREW_BOTTLE_DOMAIN=https://homebrew.bintray.com brew reinstall ruby@2.6
==> Downloading https://homebrew.bintray.com/bottles/ruby%402.6-2.6.6_1.big_sur.bottle.1.tar.gz
==> Downloading from https://d29vzk4ow07wi7.cloudfront.net/90a02e7c3985c005348fb1b750c22dce1ebbbd1a8854f3250da9956308c0c65f?response-content-disposition=attachment%3Bfilename%3D%22
######################################################################## 100.0%
==> Reinstalling ruby@2.6
**==> Pouring ruby@2.6-2.6.6_1.big_sur.bottle.1.tar.gz**

What did you expect to happen?

Bottle name to be displayed without escape characters

Step-by-step reproduction instructions (by running brew commands)

brew install ruby@2.6

HOMEBREW_BOTTLE_DOMAIN=https://homebrew.bintray.com brew reinstall ruby@2.6
@max-ae max-ae added the bug Reproducible Homebrew/brew bug label Apr 9, 2021
@MikeMcQuaid MikeMcQuaid self-assigned this Apr 9, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label May 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Reproducible Homebrew/brew bug outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants