Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

software_spec: remove debug statement #11094

Merged
merged 1 commit into from Apr 9, 2021

Conversation

nandahkrishna
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Before:

➜ brew reinstall asciiquarium
"asciiquarium--1.1_1.catalina.bottle.tar.gz"
==> Downloading https://ghcr.io/v2/homebrew/core/asciiquarium/manifests/1.1_1
Already downloaded: /Users/nanda/Library/Caches/Homebrew/downloads/38390234a9d3a8145387f34a82fb783681260f9acf16ff6b37314ab95e4471d1--asciiquarium-1.1_1.bottle_manifest.json
"asciiquarium--1.1_1.catalina.bottle.tar.gz"
==> Downloading https://ghcr.io/v2/homebrew/core/asciiquarium/blobs/sha256:9bf092861aad33c28e8f7
Already downloaded: /Users/nanda/Library/Caches/Homebrew/downloads/6de61a44e803723a045e349e55211e67d5bb4e69efd59ea0c771cb2b126b8f96--asciiquarium--1.1_1.catalina.bottle.tar.gz
==> Reinstalling asciiquarium
"asciiquarium--1.1_1.catalina.bottle.tar.gz"
==> Pouring asciiquarium--1.1_1.catalina.bottle.tar.gz
"asciiquarium--1.1_1.catalina.bottle.tar.gz"
🍺  /usr/local/Cellar/asciiquarium/1.1_1: 17 files, 373.3KB
"asciiquarium--1.1_1.catalina.bottle.tar.gz"
"asciiquarium--1.1_1.catalina.bottle.tar.gz"
"asciiquarium--1.1_1.catalina.bottle.tar.gz"
"asciiquarium--1.1_1.catalina.bottle.tar.gz"

After:

➜ brew reinstall asciiquarium
==> Downloading https://ghcr.io/v2/homebrew/core/asciiquarium/manifests/1.1_1
Already downloaded: /Users/nanda/Library/Caches/Homebrew/downloads/38390234a9d3a8145387f34a82fb783681260f9acf16ff6b37314ab95e4471d1--asciiquarium-1.1_1.bottle_manifest.json
==> Downloading https://ghcr.io/v2/homebrew/core/asciiquarium/blobs/sha256:9bf092861aad33c28e8f7
Already downloaded: /Users/nanda/Library/Caches/Homebrew/downloads/6de61a44e803723a045e349e55211e67d5bb4e69efd59ea0c771cb2b126b8f96--asciiquarium--1.1_1.catalina.bottle.tar.gz
==> Reinstalling asciiquarium
==> Pouring asciiquarium--1.1_1.catalina.bottle.tar.gz
🍺  /usr/local/Cellar/asciiquarium/1.1_1: 17 files, 373.3KB

@BrewTestBot
Copy link
Member

Review period will end on 2021-04-12 at 16:05:39 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 9, 2021
@nandahkrishna nandahkrishna added the critical Critical change which should be shipped as soon as possible. label Apr 9, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 9, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid
Copy link
Member

I removed this but rubocop prevented the file from saving in time 🤦🏻. Thanks @nandahkrishna!

@MikeMcQuaid MikeMcQuaid merged commit 0747d66 into Homebrew:master Apr 9, 2021
@nandahkrishna nandahkrishna deleted the remove-print branch April 9, 2021 16:32
@github-actions github-actions bot added the outdated PR was locked due to age label May 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants