Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_packages: handle "manifest unknown" #11118

Merged
merged 1 commit into from Apr 12, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Apr 12, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This seems to be very similar to "name unknown".

@BrewTestBot
Copy link
Member

Review period will end on 2021-04-13 at 18:00:06 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 12, 2021
@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Apr 12, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 12, 2021
@iMichka iMichka enabled auto-merge April 12, 2021 18:08
@iMichka iMichka merged commit f1c08c3 into Homebrew:master Apr 12, 2021
@Bo98 Bo98 deleted the ghp-manifest-unknown branch April 12, 2021 21:02
@MikeMcQuaid
Copy link
Member

Makes sense, thanks @Bo98!

@github-actions github-actions bot added the outdated PR was locked due to age label May 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants