Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cop for IO.read usage #11140

Merged
merged 1 commit into from May 12, 2021
Merged

Add cop for IO.read usage #11140

merged 1 commit into from May 12, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Apr 14, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

See the test spec file for examples of where this does/doesn't apply.

@BrewTestBot
Copy link
Member

Review period will end on 2021-04-15 at 15:14:13 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 14, 2021
MikeMcQuaid
MikeMcQuaid previously approved these changes Apr 14, 2021
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here 👏🏻

@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 15, 2021
BrewTestBot
BrewTestBot previously approved these changes Apr 15, 2021
Rylan12
Rylan12 previously approved these changes Apr 15, 2021
BrewTestBot
BrewTestBot previously approved these changes Apr 16, 2021
Rylan12
Rylan12 previously approved these changes Apr 16, 2021
@MikeMcQuaid
Copy link
Member

Looks ready to go once homebrew-core/linuxbrew-core fixed up accordingly.

@github-actions
Copy link

github-actions bot commented May 8, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@Rylan12
Copy link
Member

Rylan12 commented May 8, 2021

I opened a PR to fix the violations in homebrew/cask: Homebrew/homebrew-cask#105367

@Bo98 Bo98 merged commit 6b8ed45 into Homebrew:master May 12, 2021
@Bo98 Bo98 deleted the io-read-cop branch May 12, 2021 15:05
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants