Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/tests: simulate macOS for brew style homebrew-core #11192

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Apr 19, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We currently run brew style homebrew/core twice in the tap syntax (Linux) workflow, but both times the Homebrew/linuxbrew-core repo is checked. THis PR adds HOMEBREW_SIMULATE_MACOS_ON_LINUX=1 to the second brew style call so that Homebrew/homebrew-core is checked.

@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Apr 19, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid
Copy link
Member

THis PR adds HOMEBREW_SIMULATE_MACOS_ON_LINUX=1 to the second brew style call so that Homebrew/homebrew-core is checked.

This will happen without it because it's already tapped. If linuxbrew-core is tapped it won't try to retap homebrew-core (and vice-versa). No harm in adding, though 👍🏻

@Rylan12
Copy link
Member Author

Rylan12 commented Apr 19, 2021

Ah, yes, I see now 👍

No preference, then, for whether to merge or not

@MikeMcQuaid MikeMcQuaid merged commit 7a78e3b into Homebrew:master Apr 20, 2021
@Rylan12 Rylan12 deleted the simulate-macos-for-style branch April 20, 2021 12:14
@github-actions github-actions bot added the outdated PR was locked due to age label May 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants