Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove HOMEBREW_MAKE #11196

Merged
merged 1 commit into from
Apr 21, 2021
Merged

remove HOMEBREW_MAKE #11196

merged 1 commit into from
Apr 21, 2021

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Apr 20, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

remove HOMEBREW_MAKE block because it was undocumented.
related #11179 (comment)

MikeMcQuaid
MikeMcQuaid previously approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work again @hyuraku!

auto-merge was automatically disabled April 20, 2021 14:50

Head branch was pushed to by a user without write access

@hyuraku hyuraku dismissed a stale review via 40084fc April 21, 2021 00:59
Bo98
Bo98 reviewed Apr 21, 2021
View reviewed changes
Library/Homebrew/shims/mac/super/make
Comment on lines -3 to -4
# shellcheck disable=SC2154
# HOMEBREW_CCCFG is set by extend/ENV/super.rb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems to refer to HOMEBREW_CCCFG instead of HOMEBREW_MAKE. Is it correct for it to be removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question! As long as shellcheck passes I'm fine with it being removed if it's no longer needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the comments because brew style with shellcheck passed without them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just checking! 👍

@MikeMcQuaid MikeMcQuaid merged commit d3edf61 into Homebrew:master Apr 21, 2021
@MikeMcQuaid
Copy link
Member

Thanks again @hyuraku!

@hyuraku hyuraku deleted the remove_HOMEBREW_MAKE branch April 21, 2021 12:19
@github-actions github-actions bot added the outdated PR was locked due to age label May 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hyuraku @MikeMcQuaid @Bo98