Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bump-formula-pr for taps with ssh remote url. #11231

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Fix bump-formula-pr for taps with ssh remote url. #11231

merged 1 commit into from
Apr 23, 2021

Conversation

zachauten
Copy link
Contributor

@zachauten zachauten commented Apr 23, 2021 •
edited by MikeMcQuaid

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #11229

@BrewTestBot
Copy link
Member

Review period will end on 2021-04-26 at 02:16:26 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 23, 2021
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Apr 23, 2021
MikeMcQuaid
MikeMcQuaid approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, nice work @zachauten!

@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 23, 2021
@MikeMcQuaid MikeMcQuaid merged commit 06c5167 into Homebrew:master Apr 23, 2021
@SMillerDev
Copy link
Member

Thanks @zachauten !

@zachauten zachauten deleted the bump_ssh branch April 23, 2021 13:13
@github-actions github-actions bot added the outdated PR was locked due to age label May 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew bump-formula-pr fails on tap with a non-http checkout
4 participants
@zachauten @BrewTestBot @SMillerDev @MikeMcQuaid