Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor install.sh bash style fixes #11238

Merged
merged 5 commits into from Apr 26, 2021
Merged

Vendor install.sh bash style fixes #11238

merged 5 commits into from Apr 26, 2021

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Apr 23, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

related #11178

MikeMcQuaid
MikeMcQuaid reviewed Apr 23, 2021
View reviewed changes
Library/Homebrew/cmd/vendor-install.sh Outdated
@@ -3,41 +3,44 @@
#:
#: Install Homebrew's portable Ruby.

source "$HOMEBREW_LIBRARY/Homebrew/utils/lock.sh"
# HOMEBREW_CURLRC, HOMEBREW_LIBRARY, HOMEBREW_STDERR is from the user environment
# HOMEBREW_CACHE, HOMEBREW_CURL, HOMEBREW_LINUX, HOMEBREW_LINUX_MINIMUM_GLIBC_VERSION, HOMEBREW_MACOS, HOMEBREW_MACOS_VERSION_NUMERIC, HOMEBREW_PROCESSOR is set by brew.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# HOMEBREW_CACHE, HOMEBREW_CURL, HOMEBREW_LINUX, HOMEBREW_LINUX_MINIMUM_GLIBC_VERSION, HOMEBREW_MACOS, HOMEBREW_MACOS_VERSION_NUMERIC, HOMEBREW_PROCESSOR is set by brew.sh
# HOMEBREW_CACHE, HOMEBREW_CURL, HOMEBREW_LINUX, HOMEBREW_LINUX_MINIMUM_GLIBC_VERSION, HOMEBREW_MACOS,
# HOMEBREW_MACOS_VERSION_NUMERIC and HOMEBREW_PROCESSOR are set by brew.sh

Library/Homebrew/cmd/vendor-install.sh Show resolved Hide resolved
Library/Homebrew/cmd/vendor-install.sh Outdated

VENDOR_DIR="$HOMEBREW_LIBRARY/Homebrew/vendor"
VENDOR_DIR="${HOMEBREW_LIBRARY}/Homebrew/vendor"

# Built from https://github.com/Homebrew/homebrew-portable-ruby.
#
# Dynamic variables can't be detected by shellcheck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment can also be removed if the disable below can be

@hyuraku hyuraku force-pushed the vendor-install.sh_bash_style_fixes branch from d5f595b to e82e4ea Compare April 23, 2021 15:03
MikeMcQuaid
MikeMcQuaid previously approved these changes Apr 23, 2021
View reviewed changes
@MikeMcQuaid MikeMcQuaid merged commit c5bcfe8 into Homebrew:master Apr 26, 2021
@MikeMcQuaid
Copy link
Member

Thanks again @hyuraku!

@Bo98 Bo98 mentioned this pull request Apr 28, 2021
Closed
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label May 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hyuraku @MikeMcQuaid @GauthamGoli