dev-cmd/bottle: tweak tar and tar arguments. #11251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added
the
critical
5 tasks
|
Review period skipped due to |
BrewTestBot
previously approved these changes
Apr 26, 2021
Instead of using `libarchive` on macOS (which has a non-zero dependency tree) let's instead use `gnu-tar` because: - it has no dependencies - we're already using it on Linux I tested this locally with `ack` (which was getting reproducible bottles with system and Homebrew `libarchive`) and saw a different checksum. A quick read of the `gtar` manpage indicated that it uses a GNU tar format by default which can be made consistent with BSD and GNU tar by using `--format=ustar` with both. Once this is done, the checksums are the same. This will hopefully ease the transition to having `all:` bottles be consistent on Linux, too, which will be useful when homebrew-core is fully merged/supporting Linux.
MikeMcQuaid
force-pushed
the
bottle_tar_args
branch
from
1be20cb
to
a10f436
Compare
BrewTestBot
approved these changes
Apr 26, 2021
|
If this sticks: we could potentially remove the |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
libarchiveon macOS (which has a non-zero dependency tree) let's instead usegnu-tarbecause:I tested this locally with
ack(which was getting reproducible bottles with system and Homebrewlibarchive) and saw a different checksum. A quick read of thegtarmanpage indicated that it uses a GNU tar format by default which can be made consistent with BSD and GNU tar by using--format=ustarwith both. Once this is done, the checksums are the same. This will hopefully ease the transition to havingall:bottles be consistent on Linux, too, which will be useful when homebrew-core is fully merged/supporting Linux.