Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interesting-Taps-and-Forks.md: add gromgit/fuse #11255

Merged
merged 2 commits into from Apr 27, 2021
Merged

Interesting-Taps-and-Forks.md: add gromgit/fuse #11255

merged 2 commits into from Apr 27, 2021

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented Apr 27, 2021

Still a work in progress, but I've gotten the release process pretty much worked out.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot
Copy link
Member

Review period will end on 2021-04-28 at 03:55:23 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 27, 2021
carlocab
carlocab previously approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gromgit!

@gromgit @nandahkrishna
Update docs/Interesting-Taps-and-Forks.md
f2fb762 
Co-authored-by: Nanda H Krishna <me@nandahkrishna.com>
nandahkrishna
nandahkrishna approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gromgit!

@MikeMcQuaid
Copy link
Member

Thanks again @gromgit!

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Apr 27, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 27, 2021
@MikeMcQuaid MikeMcQuaid merged commit 43643d2 into Homebrew:master Apr 27, 2021
@gromgit gromgit deleted the patch-3 branch April 27, 2021 14:18
@github-actions github-actions bot added the outdated PR was locked due to age label May 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@nandahkrishna nandahkrishna nandahkrishna approved these changes

@carlocab carlocab carlocab left review comments

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gromgit @BrewTestBot @MikeMcQuaid @carlocab @nandahkrishna