Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops/shell_commands: add cop for shell metacharacters in exec #11309

Merged
merged 1 commit into from May 12, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented May 3, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Invoking the shell in exec causes the process to be detached from brew, which causes problems when running pkill in formula tests.

@BrewTestBot
Copy link
Member

Review period will end on 2021-05-04 at 19:27:57 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label May 3, 2021
@Bo98 Bo98 force-pushed the exec-cop branch 3 times, most recently from 8105c1a to a1f6c6f Compare May 3, 2021 21:20
MikeMcQuaid
MikeMcQuaid previously approved these changes May 4, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label May 4, 2021
@BrewTestBot
Copy link
Member

Review period ended.

BrewTestBot
BrewTestBot previously approved these changes May 4, 2021
@Bo98 Bo98 merged commit 6c9ef43 into Homebrew:master May 12, 2021
@Bo98 Bo98 deleted the exec-cop branch May 12, 2021 12:03
@MikeMcQuaid
Copy link
Member

Great work here @Bo98!

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants