Stop using shallow clones

[cnnrmnn]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Closes #8607.

Do taps use download strategies? If so, I'll need to make some changes since shallow clones are allowed for third-party taps.

[MikeMcQuaid]

Do taps use download strategies?

Nope!

If so, I'll need to make some changes since shallow clones are allowed for third-party taps.

Yes, that'd be great, thanks!

[cnnrmnn]

Yes, that'd be great, thanks!

I asked because my current changes would've broken tap shallow cloning if taps used download strategies. Should I make additional modifications to stop allowing shallow clones for third-party taps?

[Rylan12]

Do taps use download strategies?

Nope!

Maybe I misunderstand the question or answer but taps do use these download strategies.

If so, I'll need to make some changes since shallow clones are allowed for third-party taps.

I asked because my current changes would've broken tap shallow cloning if taps used download strategies. Should I make additional modifications to stop allowing shallow clones for third-party taps?

I think if we're shallow clones internally, they shouldn't be supported at all by the download strategy, even for this party taps.

If a tap really needs to have shallow clones, they can always write their own strategy to use them.

[cnnrmnn]

Maybe I misunderstand the question or answer but taps do use these download strategies.

Fairly certain you understand my question.

[MikeMcQuaid]

I think if we're shallow clones internally, they shouldn't be supported at all by the download strategy, even for this party taps.
If a tap really needs to have shallow clones, they can always write their own strategy to use them.

Agreed!

[MikeMcQuaid]

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @cnnrmnn!

[cnnrmnn]

My pleasure! Do I need to open a new issue to remove the tap commands that allow shallow clones or can I take that straight to a PR?

[carlocab]

Feel free to open a PR, I think.

How does this affect formulae that do a Git checkout in the url, and specify shallow: false as an argument, if at all? Just double-checking to know how urgently changes need to be made to formulae in Homebrew/core.

[MikeMcQuaid]

can I take that straight to a PR?

Go straight to a PR!

How does this affect formulae that do a Git checkout in the url, and specify shallow: false as an argument, if at all? Just double-checking to know how urgently changes need to be made to formulae in Homebrew/core.

shallow: false just became a no-op. No urgency.