Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend/os/mac/keg_relocate: remove RPATHs rooted in build directory #11382

Merged
merged 1 commit into from May 15, 2021

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Keeping dangling RPATHs is a security risk, and is bad for build
reproducibility.


I'm tempted to remove all RPATHs referencing non-existent directories, but I don't know if that will break anything.

Note that delegating delete_rpath doesn't work here. See Homebrew/ruby-macho#355.

@BrewTestBot
Copy link
Member

Review period will end on 2021-05-14 at 23:46:37 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label May 13, 2021
@carlocab
Copy link
Member Author

Re deleting RPATHs that reference non-existent directories: I'd revisit it when we're happy with the current relocation code. I don't want to change too many things at once here.

Keeping dangling `RPATH`s is a security risk, and is bad for build
reproducibility.
@carlocab carlocab enabled auto-merge May 14, 2021 15:53
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label May 15, 2021
@carlocab carlocab merged commit d45832b into Homebrew:master May 15, 2021
@carlocab carlocab deleted the build-rpaths branch May 15, 2021 04:51
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants