Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add branch param #11410

Merged
merged 2 commits into from May 19, 2021
Merged

feat: add branch param #11410

merged 2 commits into from May 19, 2021

Conversation

WingLim
Copy link
Contributor

@WingLim WingLim commented May 19, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

See the Disscusions: Homebrew/discussions#1492

Add a --branch param for pr-publish.
So that we could trigger github action with pr-publish in a tap(Third Party Repository) without using master as default branch.

And for keeping homebrew-core work normally, the default is set to master, so no need to change the github actions in homebrew-core.

MikeMcQuaid
MikeMcQuaid previously approved these changes May 19, 2021
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @WingLim!

carlocab
carlocab previously approved these changes May 19, 2021
Library/Homebrew/dev-cmd/pr-publish.rb Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid dismissed stale reviews from carlocab and themself via 2bd71ff May 19, 2021 10:36
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@MikeMcQuaid MikeMcQuaid merged commit d983c42 into Homebrew:master May 19, 2021
@WingLim WingLim deleted the develop branch May 19, 2021 11:03
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants