livecheck/strategy/sparkle: install bundler gems #11420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This PR should fix #11419, at least on Intel Macs. The
Sparkle
strategy used inlivecheck
blocks currently usesnokogiri
to extract content. On updates to this (vendored) gem, users would see errors on runningbrew livecheck
for some Casks.This PR ensures
Homebrew.install_bundler_gems!
is run beforerequire "nokogiri"
in theSparkle
strategy.(Note: This will unfortunately not fix the issue on ARM Macs, as pointed out in Homebrew/discussions#1299 (reply in thread). We might have to move away from
nokogiri
or find some other solution for that issue.)