service: ensure environment variables are strings

[SMillerDev]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[BrewTestBot]

Review period will end on 2021-05-25 at 00:00:00 UTC.

[Bo98]

Can you mention what issue this is solving (here, not in code)? Not entirely sure what error this was causing before.

[SMillerDev]

The issue is represented in the test block. If you used a pathname in a variable it would render in the plist as "data" instead of the path as a string.

[Bo98]

Oh right, I see we do StandardOutPath etc string conversion earlier. That's what confused me - I thought it was dealing with Pathname fine there.

[Bo98]

Would it make sense to do @environment_variables = variables.transform_values(&:to_s) on line 108 instead, for consistency? Doesn't really matter much though.

[SMillerDev]

I think we can

[BrewTestBot]

Review period ended.

[SMillerDev]

Typecheck is not happy and I'm not sure why

[Bo98]

Seems to think it could be nil here but it can’t. Could make wrap it as T.must(variables).transform_values(...

[SMillerDev]

Seems to think it could be nil here but it can’t. Could make wrap it as T.must(variables).transform_values(...

I think this class has equal parts Sorbet and normal code... Okay, I'll try. I have to rebase anyway

[SMillerDev]

Since it hash an empty hash as fallback I guess it simply can't be null