Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: ensure environment variables are prefixed in command #11428

Merged
merged 2 commits into from May 25, 2021
Merged

service: ensure environment variables are prefixed in command #11428

merged 2 commits into from May 25, 2021

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot
Copy link
Member

Review period will end on 2021-05-25 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label May 22, 2021
@SMillerDev SMillerDev force-pushed the fix/service/env_variables_manual branch 2 times, most recently from 88f4219 to c522eb1 Compare May 22, 2021 15:44
dawidd6
dawidd6 previously approved these changes May 22, 2021
View reviewed changes
Rylan12
Rylan12 previously approved these changes May 23, 2021
View reviewed changes
Library/Homebrew/service.rb Outdated Show resolved Hide resolved
@SMillerDev SMillerDev dismissed stale reviews from Rylan12 and dawidd6 via 5aec215 May 24, 2021 12:31
@SMillerDev SMillerDev force-pushed the fix/service/env_variables_manual branch from c522eb1 to 5aec215 Compare May 24, 2021 12:31
Bo98
Bo98 reviewed May 24, 2021
View reviewed changes
Library/Homebrew/service.rb Outdated Show resolved Hide resolved
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label May 25, 2021
@BrewTestBot
Copy link
Member

Review period ended.

BrewTestBot
BrewTestBot previously approved these changes May 25, 2021
View reviewed changes
BrewTestBot
BrewTestBot previously approved these changes May 25, 2021
View reviewed changes
@SMillerDev SMillerDev force-pushed the fix/service/env_variables_manual branch from 901c28c to 4f01352 Compare May 25, 2021 09:49
@SMillerDev SMillerDev requested a review from Bo98 May 25, 2021 10:05
@SMillerDev SMillerDev merged commit 6f1398a into Homebrew:master May 25, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2021
@SMillerDev SMillerDev deleted the fix/service/env_variables_manual branch September 21, 2022 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@dawidd6 dawidd6 dawidd6 left review comments

@Rylan12 Rylan12 Rylan12 left review comments

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SMillerDev @BrewTestBot @Bo98 @dawidd6 @Rylan12