Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service: add additional options #11430

Merged

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Adds some of the missing launchctl settings.

@BrewTestBot
Copy link
Member

Review period will end on 2021-05-25 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label May 22, 2021
@carlocab
Copy link
Member

Can we also have an option to override the manual command, just like with plist_options manual:? Sometimes the command you want to run manually is different. See, for example, emacs.

@SMillerDev
Copy link
Member Author

Not as part of this PR iyam, but I think that should be possible.

Rylan12
Rylan12 previously approved these changes May 23, 2021
Library/Homebrew/service.rb Outdated Show resolved Hide resolved
Library/Homebrew/service.rb Outdated Show resolved Hide resolved
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label May 25, 2021
@SMillerDev SMillerDev merged commit 1bdfacd into Homebrew:master May 25, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2021
@SMillerDev SMillerDev deleted the feature/service/additional_options branch September 21, 2022 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants