Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change https://api.github.com to API_URL #11480

Merged
merged 1 commit into from Jun 2, 2021

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Jun 2, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

change https://api.github.com to const API_URL like the others in utils/github.rb.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @hyuraku!

@MikeMcQuaid MikeMcQuaid merged commit 995baa9 into Homebrew:master Jun 2, 2021
@hyuraku hyuraku deleted the use_const_API_URL branch June 2, 2021 12:56
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants