Tweak BuildPulse/rspec-retry logic
#11598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added
the
critical
|
Review period ended. |
BrewTestBot
previously approved these changes
Jun 25, 2021
carlocab
reviewed
Jun 25, 2021
carlocab
reviewed
Jun 25, 2021
MikeMcQuaid
force-pushed
the
buildpulse-retry
branch
from
89b9ab1
to
0bc0d4c
Compare
BrewTestBot
previously approved these changes
Jun 25, 2021
MikeMcQuaid
force-pushed
the
buildpulse-retry
branch
from
0bc0d4c
to
06c4e3c
Compare
BrewTestBot
previously approved these changes
Jun 25, 2021
MikeMcQuaid
force-pushed
the
buildpulse-retry
branch
from
06c4e3c
to
87782eb
Compare
BrewTestBot
previously approved these changes
Jun 25, 2021
MikeMcQuaid
force-pushed
the
buildpulse-retry
branch
from
87782eb
to
19e0592
Compare
BrewTestBot
previously approved these changes
Jun 25, 2021
jasonrudolph
previously approved these changes
Jun 25, 2021
| # Retry multiple times when using BuildPulse to detect and submit | ||
| # flakiness (because rspec-retry is disabled). | ||
| if [ -n "$HOMEBREW_BUILDPULSE_ACCESS_KEY_ID" ]; then | ||
| brew tests --online --coverage || \ |
There was a problem hiding this comment.
A quick question to check my understanding of things: Am I right in thinking that each call to brew tests will run the Homebrew.tests method?
MikeMcQuaid
dismissed stale reviews from jasonrudolph and BrewTestBot
via
01d0474
MikeMcQuaid
force-pushed
the
buildpulse-retry
branch
from
19e0592
to
01d0474
Compare
BrewTestBot
previously approved these changes
Jun 28, 2021
MikeMcQuaid
force-pushed
the
buildpulse-retry
branch
from
01d0474
to
d42aff2
Compare
BrewTestBot
previously approved these changes
Jun 28, 2021
BuildPulse is trying to find flaky tests for us but, given the previous model of using `rspec-retry`, it would rarely find them. Instead, let's try to always rerun `brew tests` multiple times, report to BuildPulse each time (by moving the reporting logic into `brew tests`) and disable `rspec-retry` when using BuildPulse. While we're here, let's enable `rspec-retry` locally so we don't have flaky tests biting maintainers/contributors there.
MikeMcQuaid
force-pushed
the
buildpulse-retry
branch
from
d42aff2
to
a4c2e0e
Compare
BrewTestBot
approved these changes
Jun 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BuildPulse is trying to find flaky tests for us but, given the previous model of using
rspec-retry, it would rarely find them. Instead, let's try to always rerunbrew testsmultiple times, report to BuildPulse each time (by moving the reporting logic intobrew tests) and disablerspec-retrywhen using BuildPulse.While we're here, let's enable
rspec-retrylocally so we don't have flaky tests biting maintainers/contributors there.CC @jasonrudolph for thoughts