dispatch-build-bottle: support self-hosted Linux and unified workflow

[dawidd6]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

This is going to be needed soon, when I merge dispatch workflows into one.

Companion PR: Homebrew/homebrew-core#80015

[BrewTestBot]

Review period will end on 2021-06-28 at 17:41:55 UTC.

[dawidd6]

Weird typecheck errors strike again, can I get some help?

[BrewTestBot]

Review period skipped due to critical label.

[dawidd6]

brew typecheck fails:

dev-cmd/dispatch-build-bottle.rb:86: Method `wheezy?` does not exist on `Homebrew::CLI::Args` https://srb.help/7003
    86 |      inputs[:wheezy] = args.wheezy?.to_s if args.wheezy?
                                                     ^^^^^^^^^^^^
  Got Homebrew::CLI::Args originating from:
    dev-cmd/dispatch-build-bottle.rb:41:
    41 |    args = dispatch_build_bottle_args.parse
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  Autocorrect: Use `-a` to autocorrect
    dev-cmd/dispatch-build-bottle.rb:86: Replace with `greedy?`
    86 |      inputs[:wheezy] = args.wheezy?.to_s if args.wheezy?
                                                          ^^^^^^^

dev-cmd/dispatch-build-bottle.rb:86: Method `wheezy?` does not exist on `Homebrew::CLI::Args` https://srb.help/7003
    86 |      inputs[:wheezy] = args.wheezy?.to_s if args.wheezy?
                                ^^^^^^^^^^^^
  Got Homebrew::CLI::Args originating from:
    dev-cmd/dispatch-build-bottle.rb:41:
    41 |    args = dispatch_build_bottle_args.parse
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  Autocorrect: Use `-a` to autocorrect
    dev-cmd/dispatch-build-bottle.rb:86: Replace with `greedy?`
    86 |      inputs[:wheezy] = args.wheezy?.to_s if args.wheezy?
                                     ^^^^^^^

dev-cmd/dispatch-build-bottle.rb:86: Method `wheezy?` does not exist on `Homebrew::CLI::Args` https://srb.help/7003
    86 |      inputs[:wheezy] = args.wheezy?.to_s if args.wheezy?
                                                     ^^^^^^^^^^^^
  Got Homebrew::CLI::Args originating from:
    dev-cmd/dispatch-build-bottle.rb:41:
    41 |    args = dispatch_build_bottle_args.parse
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  Autocorrect: Use `-a` to autocorrect
    dev-cmd/dispatch-build-bottle.rb:86: Replace with `greedy?`
    86 |      inputs[:wheezy] = args.wheezy?.to_s if args.wheezy?
                                                          ^^^^^^^

dev-cmd/dispatch-build-bottle.rb:86: Method `wheezy?` does not exist on `Homebrew::CLI::Args` https://srb.help/7003
    86 |      inputs[:wheezy] = args.wheezy?.to_s if args.wheezy?
                                ^^^^^^^^^^^^
  Got Homebrew::CLI::Args originating from:
    dev-cmd/dispatch-build-bottle.rb:41:
    41 |    args = dispatch_build_bottle_args.parse
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  Autocorrect: Use `-a` to autocorrect
    dev-cmd/dispatch-build-bottle.rb:86: Replace with `greedy?`
    86 |      inputs[:wheezy] = args.wheezy?.to_s if args.wheezy?
                                     ^^^^^^^
Errors: 4
Check https://docs.brew.sh/Typechecking for more information on how to resolve these errors.

[samford]

You'll need to add a type definition for wheezy? to cli/args/args.rbi with the other returns(T::Boolean) methods. Basically, Sorbet can't automatically understand methods that are generated from CLI switches, so we have to manually tell it about them in an rbi file.

[dawidd6]

Thanks. Got help on Slack too.

[MikeMcQuaid]

Looks good, nice work!

[MikeMcQuaid]

How about --linux-wheezy here?

[MikeMcQuaid]

Or even linux-debian-wheezy?

[dawidd6]

Isn't the description enough :)?

[MikeMcQuaid]

Feels a bit weird to me not not reference it in this flag but have it as --linux-* in others.