Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/utils/github_spec: fix artifact number #11603

Merged
merged 1 commit into from Jun 25, 2021
Merged

test/utils/github_spec: fix artifact number #11603

merged 1 commit into from Jun 25, 2021

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jun 25, 2021 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fix issue mentioned in #11592 with newer artifact number from recent run.
Blocking some other PRs here.

Note that there are some brew tests that always fail for me, which I am ignoring in final checkbox:

  • Testing on Rosetta causes issues for Utils::Analytics::os_arch_prefix_ci
  • HOMEBREW_GITHUB_API_TOKEN being set causes failure in brew tap-info

@BrewTestBot
Copy link
Member

Review period will end on 2021-06-28 at 18:38:33 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jun 25, 2021
@cho-m cho-m added the critical Critical change which should be shipped as soon as possible. label Jun 25, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jun 25, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@cho-m cho-m mentioned this pull request Jun 25, 2021
Merged
7 tasks
@dawidd6 dawidd6 merged commit 1456203 into Homebrew:master Jun 25, 2021
@MikeMcQuaid
Copy link
Member

Thanks for the fix @cho-m!

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2021
@cho-m cho-m deleted the fix-github_spec-artifact branch March 5, 2024 02:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@dawidd6 dawidd6 dawidd6 approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cho-m @BrewTestBot @MikeMcQuaid @dawidd6