default_prefix: set macOS default prefix on Linux if simulating it #11605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This should fix the doctor complaining on Linux in
homebrew-core
:Above snippet taken from (somewhat companion) PR: Homebrew/homebrew-core#80082
The
DEFAULT_PREFIX
should not be set to the macOS one when settingHOMEBREW_FORCE_HOMEBREW_ON_LINUX
.Since we have stricter env var (
HOMEBREW_SIMULATE_MACOS_ON_LINUX
), then use it rather than the former.Also, doctor was right complaining about this issue of course, because now every bottle built for Linux in
homebrew-core
has the prefix set to the macOS one and I gotta rebuild those formulae after this PR is merged.Example of latest Linux bottle JSON with wrong prefix:
Note that we might need to swap those two env vars set in
homebrew-core
publishing workflow, but I'm not sure if the change in this PR will somehow negatively influence the publishing process. Talking about this line:https://github.com/Homebrew/homebrew-core/blob/e80285c224946e333261436a9baa18a6faf26103/.github/workflows/publish-commit-bottles.yml#L14