New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install formulae from JSON files #11648
Conversation
Review period will end on 2021-07-06 at 00:00:00 UTC. |
1 similar comment
Review period will end on 2021-07-06 at 00:00:00 UTC. |
Could you explain the reasoning for this? Are we going to switch from git based taps to REST API ones? What about third-party taps? |
The idea is that users shouldn't need to have homebrew/core (and probably homebrew/cask, eventually) tapped in order to install a formula (or cask). These repos are huge and annoying to update, so it slows down Third party taps would still need to be installed locally, and this wouldn't remove the need for I don't know about the future, I don't think we're planning on totally scrapping git-based taps any time soon (although @MikeMcQuaid may have a different vision). I could see us creating a way for third-party taps to use this API-based install process but for the moment, its designed just for homebrew/core. |
No, I don't have any plans personally to ever do this. As you've mentioned, this approach is pretty much just for homebrew-core and homebrew-cask (and would be for linuxbrew-core were we not so close to the migration) because:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! A few comments.
Review period ended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested/optional tweaks (that may not be needed if I've misunderstood). Merge when you're happy! Great work as usual.
My latest push adds tests for the To-do items for future PRs:
|
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This PR incorporates the JSON functionality from homebrew/json into this repo. Now, if
HOMEBREW_JSON_CORE
is set, you can untap homebrew/core and install/reinstall/upgrade formulae using the defaultinstall
,reinstall
, andupgrade
commands.Additionally,
brew outdated
is now setup to work using the new versions API proposed in Homebrew/formulae.brew.sh#497 (so this PR should not be merged until the formulae.brew.sh one is merged). This will also mean thatbrew update
will show the appropriate message if a formula is out of date, even without the homebrew/core tap installed.