Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keg_relocate: swap env var #11649

Merged
merged 1 commit into from Jul 4, 2021
Merged

keg_relocate: swap env var #11649

merged 1 commit into from Jul 4, 2021

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Jul 4, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This might cause trouble for us in homebrew-core.

@BrewTestBot
Copy link
Member

Review period will end on 2021-07-06 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 4, 2021
@dawidd6 dawidd6 requested a review from iMichka July 4, 2021 13:03
@iMichka
Copy link
Member

iMichka commented Jul 4, 2021

We suspect that this will fix the error we got while bottling swig in homebrew-core for Linux:

2021-07-04T08:10:39.2645358Z �[34m==>�[0m �[1mbrew linkage --test swig�[0m
2021-07-04T08:10:40.4584391Z �[31m==>�[0m �[1m�[31mFAILED�[0m�[0m
2021-07-04T08:10:40.4584949Z Missing libraries:
2021-07-04T08:10:40.4585497Z   unexpected (libgcc_s.so.1)
2021-07-04T08:10:40.4586085Z   unexpected (libstdc++.so.6)
2021-07-04T08:10:40.4586463Z 
2021-07-04T08:10:40.4587344Z �[34m==>�[0m �[1mbrew install --only-dependencies --include-test swig�[0m
2021-07-04T08:11:14.0968351Z �[34m==>�[0m �[1mbrew test --verbose swig�[0m
2021-07-04T08:11:16.8242005Z �[31m==>�[0m �[1m�[31mFAILED�[0m�[0m
2021-07-04T08:11:16.8244170Z �[32m==>�[0m �[1mTesting swig�[0m
2021-07-04T08:11:16.8245327Z �[34m==>�[0m �[1m/home/linuxbrew/.linuxbrew/Cellar/swig/4.0.2/bin/swig -ruby test.i�[0m
2021-07-04T08:11:16.8246715Z /home/linuxbrew/.linuxbrew/Cellar/swig/4.0.2/bin/swig: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory
2021-07-04T08:11:16.8248080Z �[31mError:�[0m swig: failed
2021-07-04T08:11:16.8248823Z An exception occurred within a child process:
2021-07-04T08:11:16.8250110Z   BuildError: Failed executing: /home/linuxbrew/.linuxbrew/Cellar/swig/4.0.2/bin/swig -ruby test.i

@iMichka iMichka added the critical Critical change which should be shipped as soon as possible. label Jul 4, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 4, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@iMichka iMichka enabled auto-merge July 4, 2021 13:06
@iMichka iMichka merged commit d3c7eb3 into master Jul 4, 2021
@iMichka iMichka deleted the dawidd6-patch-1 branch July 4, 2021 13:27
@iMichka
Copy link
Member

iMichka commented Jul 4, 2021

It worked!

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants