Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula_cellar_checks: fix cpuid instruction check on Mojave #11671

Merged
merged 1 commit into from Jul 8, 2021
Merged

formula_cellar_checks: fix cpuid instruction check on Mojave #11671

merged 1 commit into from Jul 8, 2021

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Jul 8, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The output format of objdump on Mojave is different from newer
versions of macOS, so I've adjusted the relevant audit to account for
this difference.

@BrewTestBot
Copy link
Member

Review period will end on 2021-07-09 at 00:54:51 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 8, 2021
@carlocab
formula_cellar_checks: fix cpuid instruction check on Mojave
16e5690 
The output format of `objdump` on Mojave is different from newer
versions of macOS, so I've adjusted the relevant audit to account for
this difference.
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jul 8, 2021
MikeMcQuaid
MikeMcQuaid approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 8, 2021
@carlocab carlocab merged commit 0d74072 into Homebrew:master Jul 8, 2021
@carlocab carlocab deleted the cpuid-audit-mojave branch July 8, 2021 07:46
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlocab @BrewTestBot @MikeMcQuaid