Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/typecheck: error-white-list renamed to isolate-error-code #11689

Merged
merged 2 commits into from Jul 12, 2021
Merged

dev-cmd/typecheck: error-white-list renamed to isolate-error-code #11689

merged 2 commits into from Jul 12, 2021

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jul 9, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@issyl0
dev-cmd/typecheck: error-white-list renamed to isolate-error-code
6ce59fe 
- It was renamed in
  sorbet/sorbet@4ea6842
  which is included in the ancient version we're using.
@BrewTestBot
Copy link
Member

Review period will end on 2021-07-12 at 23:48:21 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 9, 2021
nandahkrishna
nandahkrishna approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! CI will be 🟢 once linuxbrew-core is updated with the change from Homebrew/homebrew-core#80931.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jul 12, 2021
@MikeMcQuaid
Copy link
Member

Thanks @issyl0!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 12, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit fc5265a into Homebrew:master Jul 12, 2021
@issyl0 issyl0 deleted the sorbet-rename-allowed-or-ignored-error-codes-parameter branch July 12, 2021 13:44
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@nandahkrishna nandahkrishna nandahkrishna approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@issyl0 @BrewTestBot @MikeMcQuaid @nandahkrishna