New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch: add --bottle-tag flag #11691
fetch: add --bottle-tag flag #11691
Conversation
Review period will end on 2021-07-13 at 00:00:00 UTC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably conflict with --build-from-source
too, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs the change @Rylan12 mentioned but otherwise looks fine. This will get cleaned by brew cleanup
but that should be fine. I assume it outputs the correct PATH?
Review period ended. |
What do you mean by saying PATH? The famous env variable? |
63c204c
to
793371a
Compare
I think Mike means the path to the downloaded bottle, as in the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great. 🎉 Thanks @dawidd6!
❯ brew fetch --bottle-tag=x86_64_linux hello
==> Downloading https://ghcr.io/v2/homebrew/core/hello/manifests/2.10
Already downloaded: /Users/carlocab/Library/Caches/Homebrew/downloads/93309a1636f67f0f51e2604bb2ece243b5a9324eda1d49e05192ed285af508cd--hello-2.10.bottle_manifest.json
==> Downloading https://ghcr.io/v2/homebrew/core/hello/blobs/sha256:e6980196298e0a9cfe4fa4e328a71a1869a4d5e1d31c38442150ed784cfc0e2
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:e6980196298e0a9cfe4fa4e328a71a1869a4d5e1d31c38
######################################################################## 100.0%
Downloaded to: /Users/carlocab/Library/Caches/Homebrew/downloads/9c334d845e8a08c0d898b81ddd616360ffd4230df01b2ab5f2a61425d19a4bcd--hello--2.10.x86_64_linux.bottle.tar.gz
SHA256: e6980196298e0a9cfe4fa4e328a71a1869a4d5e1d31c38442150ed784cfc0e29
Apparently @carlocab can understand me even when I talk drivel! I have no idea why I capitalised that 😅 |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?It would be useful for maintainers to be able to easily fetch bottles for different OSes.
Not sure if the implementation itself is fine but it works.