Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch: add --bottle-tag flag #11691

Merged
merged 1 commit into from Jul 13, 2021
Merged

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Jul 10, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

It would be useful for maintainers to be able to easily fetch bottles for different OSes.

Not sure if the implementation itself is fine but it works.

@BrewTestBot
Copy link
Member

Review period will end on 2021-07-13 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 10, 2021
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably conflict with --build-from-source too, right?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the change @Rylan12 mentioned but otherwise looks fine. This will get cleaned by brew cleanup but that should be fine. I assume it outputs the correct PATH?

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 13, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@dawidd6
Copy link
Member Author

dawidd6 commented Jul 13, 2021

What do you mean by saying PATH? The famous env variable?

@carlocab
Copy link
Member

I think Mike means the path to the downloaded bottle, as in the Downloaded to: line here:

❯ brew fetch hello
==> Downloading https://ghcr.io/v2/homebrew/core/hello/manifests/2.10
Already downloaded: /Users/carlocab/Library/Caches/Homebrew/downloads/93309a1636f67f0f51e2604bb2ece243b5a9324eda1d49e05192ed285af508cd--hello-2.10.bottle_manifest.json
==> Downloading https://ghcr.io/v2/homebrew/core/hello/blobs/sha256:69489ae397e4645127aa7773211310f81ebb6c99e1f8e3e22c5cdb55333f540
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:69489ae397e4645127aa7773211310f81ebb6c99e1f8e3
######################################################################## 100.0%
Downloaded to: /Users/carlocab/Library/Caches/Homebrew/downloads/e0395c201b40d07f50d44b84fccab28bb89bb292929894555688f6510f583a4c--hello--2.10.big_sur.bottle.tar.gz
SHA256: 69489ae397e4645127aa7773211310f81ebb6c99e1f8e3e22c5cdb55333f5408

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. 🎉 Thanks @dawidd6!

❯ brew fetch --bottle-tag=x86_64_linux hello
==> Downloading https://ghcr.io/v2/homebrew/core/hello/manifests/2.10
Already downloaded: /Users/carlocab/Library/Caches/Homebrew/downloads/93309a1636f67f0f51e2604bb2ece243b5a9324eda1d49e05192ed285af508cd--hello-2.10.bottle_manifest.json
==> Downloading https://ghcr.io/v2/homebrew/core/hello/blobs/sha256:e6980196298e0a9cfe4fa4e328a71a1869a4d5e1d31c38442150ed784cfc0e2
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:e6980196298e0a9cfe4fa4e328a71a1869a4d5e1d31c38
######################################################################## 100.0%
Downloaded to: /Users/carlocab/Library/Caches/Homebrew/downloads/9c334d845e8a08c0d898b81ddd616360ffd4230df01b2ab5f2a61425d19a4bcd--hello--2.10.x86_64_linux.bottle.tar.gz
SHA256: e6980196298e0a9cfe4fa4e328a71a1869a4d5e1d31c38442150ed784cfc0e29

@MikeMcQuaid
Copy link
Member

What do you mean by saying PATH? The famous env variable?

Apparently @carlocab can understand me even when I talk drivel! I have no idea why I capitalised that 😅

@dawidd6 dawidd6 merged commit 2a9f962 into Homebrew:master Jul 13, 2021
@dawidd6 dawidd6 deleted the fetch-bottle-tag branch July 13, 2021 16:51
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants