Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: check for both cases in suffix #11713

Merged
merged 1 commit into from Jul 16, 2021

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

version.rb currently checks for both cases of "rc" in version number suffixes, but only lowercase "p". This adds uppercase "P" to the list, allowing it to properly parse versions like 4.4.2-P1, which is the current release of isc-dhcp.

@BrewTestBot
Copy link
Member

Review period will end on 2021-07-15 at 01:56:22 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 14, 2021
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Jul 14, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@EricFromCanada EricFromCanada merged commit fba8dd6 into Homebrew:master Jul 16, 2021
@EricFromCanada EricFromCanada deleted the version-new-suffix branch July 16, 2021 20:43
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants