New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to JSON bottle handling #11715
Conversation
Review period will end on 2021-07-15 at 06:41:12 UTC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All makes sense to me! Some comments but optional and can be in a follow-up PR if desired.
Review period skipped due to |
When playing around locally I realized that |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Follow-up to #11648
This PR does three things to improve the way JSON bottles are handled:
BottleAPI::fetch_bottles
only downloads dependency bottles if no up-to-date version of the formula is installed locally. This means we don't need to spend time downloading bottles for all dependencies if they will never be used.brew update --preinstall
), no longer fetcheshomebrew/core
(as long asHOMEBREW_JSON_CORE
is set). Runningbrew update
manually will still fetchhomebrew/core
.brew info
now shows the most recent version information ifHOMEBREW_JSON_CORE
is set rather than the version that exists in the tap.