Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to JSON bottle handling #11715

Merged
merged 7 commits into from Jul 16, 2021
Merged

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Jul 14, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Follow-up to #11648

This PR does three things to improve the way JSON bottles are handled:

  1. BottleAPI::fetch_bottles only downloads dependency bottles if no up-to-date version of the formula is installed locally. This means we don't need to spend time downloading bottles for all dependencies if they will never be used.
  2. Automatic Homebrew updates (i.e. brew update --preinstall), no longer fetches homebrew/core (as long as HOMEBREW_JSON_CORE is set). Running brew update manually will still fetch homebrew/core.
  3. brew info now shows the most recent version information if HOMEBREW_JSON_CORE is set rather than the version that exists in the tap.

@BrewTestBot
Copy link
Member

Review period will end on 2021-07-15 at 06:41:12 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 14, 2021
Library/Homebrew/cmd/info.rb Outdated Show resolved Hide resolved
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense to me! Some comments but optional and can be in a follow-up PR if desired.

Library/Homebrew/cmd/info.rb Outdated Show resolved Hide resolved
Library/Homebrew/bottle_api.rb Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jul 14, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 14, 2021
@Rylan12
Copy link
Member Author

Rylan12 commented Jul 14, 2021

When playing around locally I realized that :all bottles were not supported, so I added support in this PR

@Rylan12 Rylan12 merged commit a4e093d into Homebrew:master Jul 16, 2021
@Rylan12 Rylan12 deleted the json-improvements branch July 16, 2021 05:51
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants