Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands: remove diy, add lc alias for livecheck #11719

Merged
merged 2 commits into from Jul 15, 2021

Conversation

nandahkrishna
Copy link
Member

@nandahkrishna nandahkrishna commented Jul 14, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally? (Ran brew tests --online, all checks passed.)

This PR makes two minor changes:

  • It removes the default alias for brew diy (configure) which no longer exists.
  • It adds lc as a default alias for livecheck, similar to tc for typecheck. The reason I'm proposing this (rather than using brew alias just for myself) is because there are 7 l* commands and 4 li* commands, so at least 4 characters (i.e. liv<TAB>) are required to autocomplete to livecheck. I think users of livecheck would like having a short alias like lc, which is convenient and unambiguous (to my knowledge).

@BrewTestBot
Copy link
Member

Review period will end on 2021-07-15 at 16:38:44 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 14, 2021
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Jul 14, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@nandahkrishna nandahkrishna merged commit 83821cf into Homebrew:master Jul 15, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
@nandahkrishna nandahkrishna deleted the commands branch January 22, 2022 03:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants