formula: fix latest_version_installed?
for HOMEBREW_JSON_CORE
#11730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Follow-up to #11715
If
HOMEBREW_JSON_CORE
is set,brew cleanup
fails:This is because the updates to
Formula#latest_version_installed?
from #11715 did not handle the case where a formula wasn't found in the/api/versions.json
file (which would happen for any non-core formula.Now, if the formula isn't listed, default back to the old way of using
latest_installed_prefix
(which is still done ifHOMEBREW_JSON_CORE
is unset.