Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-report: still report homebrew/core changes if they are updated #11733

Merged
merged 1 commit into from Jul 17, 2021

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Jul 17, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Follow-up to #11729

We also need to check whether it's a preinstall update (i.e. that --preinstall was passed). Otherwise, homebrew/core will still be updated and its updates won't be listed in the output because they'll be ignored by HOMEBREW_JSON_CORE presence.

@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Jul 17, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Rylan12 Rylan12 merged commit 12d272a into Homebrew:master Jul 17, 2021
@Rylan12 Rylan12 deleted the fix-update-report-reporting branch July 17, 2021 17:17
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants