Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/doctor: repair xattr not find #11740

Merged
merged 2 commits into from Jul 19, 2021
Merged

cmd/doctor: repair xattr not find #11740

merged 2 commits into from Jul 19, 2021

Conversation

ylht
Copy link

@ylht ylht commented Jul 19, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

There is a problem with the current way of checkingxattr command, which is simply running xattr no args and checking if it prints an error. But on macOS 12 beta3, the xattr command with no args would print an error, so the -h command is appended to fix this check.

This type of detection does not affect the previous version and does not require additional unit tests.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@MikeMcQuaid MikeMcQuaid merged commit 4c3a8c7 into Homebrew:master Jul 19, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants