Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gist-logs: grab files in subdirectories too #11803

Merged
merged 1 commit into from Aug 3, 2021

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented Aug 2, 2021

#11594 introduces subdirectories for additional logs (e.g. CMake build logs), so brew gist-logs can now throw errors like:

$ brew gist-logs gcc
Error: Is a directory @ io_fread - /home/yz/.cache/Homebrew/Logs/gcc/build

This PR grabs log files recursively, but GitHub's gists can't deal with directory separators in relative paths. Therefore, I'm also replacing all / with :, since I assume Windows support is not on the cards any time soon. This means gists will now contain paths like build:amalgamation:CMakeFiles:CMakeOutput.log, which I find more-or-less readable, but I'm open to suggestions for directory separator replacements. (I didn't use _ because that's already a common character in filenames.)

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot
Copy link
Member

Review period will end on 2021-08-03 at 06:10:15 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 2, 2021
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 3, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit a1067f9 into Homebrew:master Aug 3, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants