gist-logs: grab files in subdirectories too #11803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11594 introduces subdirectories for additional logs (e.g. CMake build logs), so
brew gist-logs
can now throw errors like:This PR grabs log files recursively, but GitHub's gists can't deal with directory separators in relative paths. Therefore, I'm also replacing all
/
with:
, since I assume Windows support is not on the cards any time soon. This means gists will now contain paths likebuild:amalgamation:CMakeFiles:CMakeOutput.log
, which I find more-or-less readable, but I'm open to suggestions for directory separator replacements. (I didn't use_
because that's already a common character in filenames.)brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?