Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula: allow std_cmake_args to take parameters #11841

Merged
merged 1 commit into from Aug 11, 2021
Merged

formula: allow std_cmake_args to take parameters #11841

merged 1 commit into from Aug 11, 2021

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Aug 10, 2021 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We have a handful of of formulae that do std_cmake_args.reject to
override some of the flags (e.g. emscripten, icemon, ortp, qt, klee,
watchman).

Let's try to simplify some of this code by allowing these formulae to
override these flags by passing arguments to std_cmake_args.

While we're here, let's update the type signature of std_cargo_args.

@carlocab
formula: allow std_cmake_args to take parameters
1243556 
We have a handful of of formulae that do `std_cmake_args.reject` to
override some of flags (e.g. emscripten, icemon, ortp, qt, klee,
watchman).

Let's try to simplify some of this code by allowing these formulae to
override these flags by passing arguments to `std_cmake_args`.

While we're here, let's update the type signature of `std_cargo_args`.
@BrewTestBot
Copy link
Member

Review period will end on 2021-08-11 at 03:59:49 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 10, 2021
Rylan12
Rylan12 approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

MikeMcQuaid
MikeMcQuaid approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, nice work!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 11, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@carlocab carlocab merged commit 66dfcd4 into Homebrew:master Aug 11, 2021
@carlocab carlocab deleted the cmake-args-params branch August 11, 2021 06:19
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlocab @BrewTestBot @MikeMcQuaid @Rylan12