Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add revision secondary sort to resolve_latest_keg #11849

Merged
merged 2 commits into from Aug 12, 2021
Merged

Add revision secondary sort to resolve_latest_keg #11849

merged 2 commits into from Aug 12, 2021

Conversation

cnnrmnn
Copy link
Contributor

@cnnrmnn cnnrmnn commented Aug 12, 2021 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Context for this change is here.

@BrewTestBot
Copy link
Member

Review period will end on 2021-08-13 at 00:11:41 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 12, 2021
Rylan12
Rylan12 approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cnnrmnn!

Library/Homebrew/cli/named_args.rb Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Aug 12, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 12, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Rylan12
Update Library/Homebrew/cli/named_args.rb
92717b6 
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
@cnnrmnn cnnrmnn merged commit 057137c into Homebrew:master Aug 12, 2021
@cnnrmnn cnnrmnn deleted the revision-secondary-sort branch August 12, 2021 14:13
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cnnrmnn @BrewTestBot @MikeMcQuaid @Rylan12