Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump-formula-pr: use default remote if forcing Homebrew on Linux #11858

Merged
merged 1 commit into from Aug 16, 2021
Merged

bump-formula-pr: use default remote if forcing Homebrew on Linux #11858

merged 1 commit into from Aug 16, 2021

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Aug 13, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

If one sets HOMEBREW_FORCE_HOMEBREW_ON_LINUX it is unnecessary to specially create new remote to check out homebrew/core, it should already be the default.

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Aug 13, 2021
@BrewTestBot
Copy link
Member

Review period will end on 2021-08-16 at 20:57:22 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 13, 2021
@Homebrew Homebrew deleted a comment from request-info bot Aug 13, 2021
@dawidd6 dawidd6 added critical Critical change which should be shipped as soon as possible. and removed needs response Needs a response from the issue/PR author labels Aug 13, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 14, 2021
@dawidd6
Copy link
Member Author

dawidd6 commented Aug 14, 2021

Marking as critical cause I'm tired of getting failed workflow notification every 3 hours...

@MikeMcQuaid MikeMcQuaid merged commit f5bad82 into master Aug 16, 2021
@MikeMcQuaid MikeMcQuaid deleted the bump-force-homebrew-on-linux branch August 16, 2021 12:09
@MikeMcQuaid
Copy link
Member

Thanks @dawidd6!

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dawidd6 @BrewTestBot @MikeMcQuaid