Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/mac/diagnostic: check min CLT version on env setup #11868

Merged
merged 1 commit into from Aug 17, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Aug 17, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This covers the case where the user has CLT 12.0-12.4 on Big Sur and is setting up the build env via non-build-from-source means (e.g. bottle :unneeded). We no longer support those versions of the CLT and they will throw errors if used.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Aug 17, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@boblail
Copy link
Contributor

boblail commented Aug 17, 2021

Tested this with a bottle :unneeded formula (and old CLT) — looks good 👍

@Bo98 Bo98 merged commit 0b41449 into Homebrew:master Aug 17, 2021
@Bo98 Bo98 deleted the clt-version-check branch August 17, 2021 18:17
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks @Bo98!

@Bo98
Copy link
Member Author

Bo98 commented Aug 17, 2021

I might tag 3.2.8 in a bit with this fix as I suspect there will be a few bug reports. There isn't much other code changing commits since the last one too so should be low risk.

@Bo98
Copy link
Member Author

Bo98 commented Aug 18, 2021

3.2.8 is released now. Thanks @boblail for the initial report and testing this out.

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants