Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bin/brew: actually quiet cd #11887

Merged
merged 1 commit into from Aug 20, 2021
Merged

bin/brew: actually quiet cd #11887

merged 1 commit into from Aug 20, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Aug 19, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #11886.

@BrewTestBot
Copy link
Member

Review period will end on 2021-08-20 at 12:34:41 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 19, 2021
@Bo98 Bo98 mentioned this pull request Aug 19, 2021
Closed
2 tasks
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Aug 19, 2021
MikeMcQuaid
MikeMcQuaid approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bo98!

@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 19, 2021
@Bo98 Bo98 merged commit e3876e8 into Homebrew:master Aug 20, 2021
@Bo98 Bo98 deleted the quiet_cd branch August 20, 2021 01:51
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

line 11: cd: /usr/local/Homebrew/bin: No such file or directory
3 participants
@Bo98 @BrewTestBot @MikeMcQuaid