New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sandbox: start sandbox in a pseudoterminal #11914
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
added
the
critical
Critical change which should be shipped as soon as possible.
label
Aug 24, 2021
Review period skipped due to |
BrewTestBot
approved these changes
Aug 24, 2021
MikeMcQuaid
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it out.
MikeMcQuaid
reviewed
Aug 24, 2021
MikeMcQuaid
approved these changes
Aug 24, 2021
Bo98
commented
Aug 24, 2021
MikeMcQuaid
approved these changes
Aug 24, 2021
This was referenced Sep 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This disconnects the sandbox from directly accessing the parent terminal.
Due to the wide range of formulae we have and how some of the tests we have can be pretty picky on the terminal, particularly for those that do things like manually setting
TERM
, changing thewinsize
or doing some fancy things inexpect
, I can't give 100% assurances this will be regression free but it does seem the work on a couple that I tried. It's very much possible nothing will break and I'm being overly cautious - there's just too much variation for me to guarantee anything.In the event someone feels the need to revert this quickly, but the only thing breaking is (multiple) tests, I suggest a partial revert by adding a kwarg to conditionally disable this for tests (but not builds/postinstall) should time allow.