Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandbox: start sandbox in a pseudoterminal #11914

Merged
merged 3 commits into from Aug 24, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Aug 24, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This disconnects the sandbox from directly accessing the parent terminal.

Due to the wide range of formulae we have and how some of the tests we have can be pretty picky on the terminal, particularly for those that do things like manually setting TERM, changing the winsize or doing some fancy things in expect, I can't give 100% assurances this will be regression free but it does seem the work on a couple that I tried. It's very much possible nothing will break and I'm being overly cautious - there's just too much variation for me to guarantee anything.

In the event someone feels the need to revert this quickly, but the only thing breaking is (multiple) tests, I suggest a partial revert by adding a kwarg to conditionally disable this for tests (but not builds/postinstall) should time allow.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Aug 24, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it out.

Library/Homebrew/sandbox.rb Outdated Show resolved Hide resolved
Library/Homebrew/sandbox.rb Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid merged commit 216eb45 into Homebrew:master Aug 24, 2021
@Bo98 Bo98 deleted the sandbox-pty branch August 24, 2021 15:47
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants